Merge pull request #342 from namoscato/drivers-doctrine

Move Doctrine driver to new namespace
bernardphp · Feb 11, 2018 · fdcdad8 · fdcdad8
2 parents 3f42ede + 1b9aa4a
commit fdcdad8
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 33 deletions.
diff --git a/doc/drivers.rst b/doc/drivers.rst
@@ -175,7 +175,7 @@ And here is the setup of the driver for doctrine dbal:
 
     <?php
 
-    use Bernard\Driver\DoctrineDriver;
+    use Bernard\Driver\Doctrine\Driver;
     use Doctrine\DBAL\DriverManager;
 
     $connection = DriverManager::getConnection(array(
@@ -186,7 +186,7 @@ And here is the setup of the driver for doctrine dbal:
     ));
 
 
-    $driver = new DoctrineDriver($connection);
+    $driver = new Driver($connection);
 
 Flatfile
 --------

diff --git a/example/doctrine.php b/example/doctrine.php
@@ -1,6 +1,6 @@
 <?php
 
-use Bernard\Driver\DoctrineDriver;
+use Bernard\Driver\Doctrine\Driver;
 use Doctrine\DBAL\DriverManager;
 
 /**
@@ -16,7 +16,7 @@ function get_driver() {
         'driver' => 'pdo_mysql',
     ));
 
-    $doctrineDriver = new DoctrineDriver($connection);
+    $doctrineDriver = new Driver($connection);
 
     //Don't do this in your application. Use a database set up script instead.
     try {

diff --git a/src/Driver/DoctrineDriver.php → src/Driver/Doctrine/Driver.php b/src/Driver/DoctrineDriver.php → src/Driver/Doctrine/Driver.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Bernard\Driver;
+namespace Bernard\Driver\Doctrine;
 
 use Doctrine\DBAL\Connection;
 
@@ -9,9 +9,9 @@
  *
  * @package Bernard
  */
-class DoctrineDriver implements \Bernard\Driver
+final class Driver implements \Bernard\Driver
 {
-    protected $connection;
+    private $connection;
 
     /**
      * {@inheritdoc}
@@ -154,7 +154,7 @@ public function info()
      *
      * @return array|null
      */
-    protected function doPopMessage($queueName)
+    private function doPopMessage($queueName)
     {
         $query = 'SELECT id, message FROM bernard_messages
                   WHERE queue = :queue AND visible = :visible

diff --git a/tests/Driver/AbstractDoctrineDriverTest.php → tests/Driver/Doctrine/AbstractDriverTest.php b/tests/Driver/AbstractDoctrineDriverTest.php → tests/Driver/Doctrine/AbstractDriverTest.php
@@ -1,21 +1,21 @@
 <?php
 
-namespace Bernard\Tests\Driver;
+namespace Bernard\Tests\Driver\Doctrine;
 
 use Bernard\Doctrine\MessagesSchema;
-use Bernard\Driver\DoctrineDriver;
+use Bernard\Driver\Doctrine\Driver;
 use Doctrine\DBAL\Platforms\MySqlPlatform;
 use Doctrine\DBAL\Schema\Schema;
 
-abstract class AbstractDoctrineDriverTest extends \PHPUnit\Framework\TestCase
+abstract class AbstractDriverTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @var \Doctrine\DBAL\Connection
      */
     private $connection;
 
     /**
-     * @var DoctrineDriver
+     * @var Driver
      */
     protected $driver;
 
@@ -30,7 +30,7 @@ public function setUp()
         }
 
         $this->setUpDatabase();
-        $this->driver = new DoctrineDriver($this->connection);
+        $this->driver = new Driver($this->connection);
     }
 
     protected function tearDown()
@@ -171,10 +171,10 @@ protected function setUpDatabase()
     /**
      * @return \Doctrine\DBAL\Connection
      */
-    protected abstract function createConnection();
+    abstract protected function createConnection();
 
     /**
      * @return bool
      */
-    protected abstract function isSupported();
+    abstract protected function isSupported();
 }
diff --git a/tests/Driver/MySQLDoctrineDriverTest.php → tests/Driver/Doctrine/MySQLDriverTest.php b/tests/Driver/MySQLDoctrineDriverTest.php → tests/Driver/Doctrine/MySQLDriverTest.php
@@ -1,17 +1,13 @@
 <?php
 
-namespace Bernard\Tests\Driver;
-
-use Bernard\Doctrine\MessagesSchema;
-use Bernard\Driver\DoctrineDriver;
+namespace Bernard\Tests\Driver\Doctrine;
 
 use Doctrine\DBAL\DriverManager;
-use Doctrine\DBAL\Schema\Schema;
 
 /**
  * @group functional
  */
-class MySQLDoctrineDriverTest extends AbstractDoctrineDriverTest
+class MySQLDriverTest extends AbstractDriverTest
 {
     protected function isSupported()
     {

diff --git a/...s/Driver/PostgreSQLDoctrineDriverTest.php → .../Driver/Doctrine/PostgreSQLDriverTest.php b/...s/Driver/PostgreSQLDoctrineDriverTest.php → .../Driver/Doctrine/PostgreSQLDriverTest.php
@@ -1,17 +1,13 @@
 <?php
 
-namespace Bernard\Tests\Driver;
-
-use Bernard\Doctrine\MessagesSchema;
-use Bernard\Driver\DoctrineDriver;
+namespace Bernard\Tests\Driver\Doctrine;
 
 use Doctrine\DBAL\DriverManager;
-use Doctrine\DBAL\Schema\Schema;
 
 /**
  * @group functional
  */
-class PostgreSQLDoctrineDriverTest extends AbstractDoctrineDriverTest
+class PostgreSQLDriverTest extends AbstractDriverTest
 {
     protected function isSupported()
     {

diff --git a/tests/Driver/SQLiteDoctrineDriverTest.php → tests/Driver/Doctrine/SQLiteDriverTest.php b/tests/Driver/SQLiteDoctrineDriverTest.php → tests/Driver/Doctrine/SQLiteDriverTest.php
@@ -1,17 +1,13 @@
 <?php
 
-namespace Bernard\Tests\Driver;
-
-use Bernard\Doctrine\MessagesSchema;
-use Bernard\Driver\DoctrineDriver;
+namespace Bernard\Tests\Driver\Doctrine;
 
 use Doctrine\DBAL\DriverManager;
-use Doctrine\DBAL\Schema\Schema;
 
 /**
  * @group functional
  */
-class SQLiteDoctrineDriverTest extends AbstractDoctrineDriverTest
+class SQLiteDriverTest extends AbstractDriverTest
 {
     protected function isSupported()
     {