Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Beanstalk driver to new namespace #340

Merged
merged 2 commits into from
Feb 11, 2018

Conversation

namoscato
Copy link

@namoscato namoscato commented Nov 19, 2017

See #256.

Copy link
Member

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@reinfi
Copy link

reinfi commented Nov 22, 2017

now in englisch :D the namespace should be beanstalkd because that is the queue name.

@namoscato
Copy link
Author

Cool, yeah happy to change that. Another option I considered is a more specific Pheanstalk namespace.

@acrobat
Copy link
Member

acrobat commented Nov 23, 2017

With our current requirement of the "pda/pheanstalk" lib, a pheanstalk namespace would be more correct imo

What do you think @sagikazarmark?

@sagikazarmark
Copy link
Contributor

I don't mind either way. The current name is pheanstalk, so sticking to it probably makes the transition easier for others.

Also, thanks for your outstanding work @namoscato , sorry I haven't responded earlier. I will try to review your PRs before the end of the year, that's the best I can promise at the moment.

@acrobat
Copy link
Member

acrobat commented Nov 23, 2017

I will also try to go through all pr's and submit a review. Hopefully this will make it easier to merge (or atleast quicker)

@sagikazarmark
Copy link
Contributor

@namoscato thanks a lot, outstanding work!

@sagikazarmark sagikazarmark merged commit ce2bdcf into bernardphp:drivers Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants