Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect active form element more accurately #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ <h1>bespoke-forms</h1>
<div contenteditable="true">This div is editable</div>
</section>
<section>
<input type="text" value="readonly" readonly />
</section>
</article>

Expand Down
16 changes: 9 additions & 7 deletions dist/bespoke-forms.js
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
/*!
* bespoke-forms v1.0.0
*
* Copyright 2014, Mark Dalgleish
* Copyright 2015, Mark Dalgleish
* This content is released under the MIT license
* http://mit-license.org/markdalgleish
*/

!function(e){if("object"==typeof exports&&"undefined"!=typeof module)module.exports=e();else if("function"==typeof define&&define.amd)define([],e);else{var o;"undefined"!=typeof window?o=window:"undefined"!=typeof global?o=global:"undefined"!=typeof self&&(o=self);var f=o;f=f.bespoke||(f.bespoke={}),f=f.plugins||(f.plugins={}),f.forms=e()}}(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(_dereq_,module,exports){
module.exports = function() {
return function(deck) {
deck.slides.forEach(function(slide) {
slide.addEventListener('keydown', function(e) {
if (/INPUT|TEXTAREA|SELECT/.test(e.target.nodeName) || e.target.contentEditable === 'true') {
e.stopPropagation();
}
});
var acceptsInput = function(element) {
return ('disabled' in element) || element.contentEditable === 'true';
};

deck.parent.addEventListener('keydown', function(e) {
if (acceptsInput(e.target)) {
e.stopPropagation();
}
});
};
};
Expand Down
4 changes: 2 additions & 2 deletions dist/bespoke-forms.min.js
100755 → 100644

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions lib/bespoke-forms.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
module.exports = function() {
return function(deck) {
deck.slides.forEach(function(slide) {
slide.addEventListener('keydown', function(e) {
if (/INPUT|TEXTAREA|SELECT/.test(e.target.nodeName) || e.target.contentEditable === 'true') {
e.stopPropagation();
}
});
var acceptsInput = function(element) {
return ('disabled' in element) || element.contentEditable === 'true';
};

deck.parent.addEventListener('keydown', function(e) {
if (acceptsInput(e.target)) {
e.stopPropagation();
}
});
};
};
9 changes: 4 additions & 5 deletions test/spec/bespoke-formsSpec.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
Function.prototype.bind = Function.prototype.bind || require('function-bind');

var bespoke = require('bespoke');
var keys = require('bespoke-keys');
var forms = require('../../lib-instrumented/bespoke-forms.js');

require('simulant/simulant');
var bespoke = require('bespoke'),
keys = require('bespoke-keys'),
forms = require('../../lib-instrumented/bespoke-forms.js'),
simulant = require('simulant');

describe("bespoke-forms", function() {

Expand Down