Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bundle the DSFR within the app #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

freesteph
Copy link
Collaborator

@freesteph freesteph commented Jan 8, 2025

En résumé : on a tout intérêt à shipper le DSFR nous-mêmes, je vous laisse lire le commit log pour de plus amples explications.

Je suppose qu'on devrait même passer à 3 pour la major version, malgré le récent passage à 2, qu'en pensez-vous ?

@freesteph freesteph requested a review from adipasquale January 8, 2025 08:51
Right, so until now we were relying on the host app to provide the
DSFR. That's not great because we provide components that spit out
DSFR markup, which is obviously tied to their current release.

So if DSFR version 1000 says a button is:

<button class="fr-btn">Oui</button>

but the DSFR version 2000 says it's actually:

<button class="fr-button">Oui</button>

We have absolutely no way to adjust. So instead ship some bits of the
DSFR ourselves :

* the minimum stylesheet;
* the icons;
* the fonts.

This also means that the host apps don't need to install NodeJS
anymore if they solely rely on it to install the DSFR. In other words,
if your only package is `@gouvfr/dsfr`, you can now just use the gem
and remove Node from your pipeline. Glory glory hallelujah!

This was inspired by my fellow DSFR packager Sylvain during a coffee
break.

Suggested-by: Sylvain Boissel <[email protected]>
@freesteph freesteph force-pushed the feat/bundle-the-dsfr branch from 98a48fe to eb780c5 Compare January 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant