-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop automatically generating meta files for assets while using asset processing. #17216
base: main
Are you sure you want to change the base?
Conversation
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
I don't think this PR needs a migration guide since users don't need to change any existing stuff for their assets to work. New assets will also continue to work, though new meta files will have to be created using the provided function or manually created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Do we want to wait for cart to weigh in on this?
In terms of guides, I can write up something once all changes are in and the dust has settled. Not a migration guide so much as a description of the new workflow. |
Objective
Solution
AssetServer::write_default_meta_file_for_path
Testing
write_default_meta_file_for_path
since we don't have an in-memory asset writer. Writing one could be useful in the future.Showcase
Asset processing no longer automatically generates meta files! This makes it much easier to transition to using asset processing since you don't suddenly get many meta files when turning it on.
You can still manually generate meta files using the new
AssetServer::write_default_meta_file_for_path
function.