Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_winit: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17232

Merged
merged 2 commits into from
Jan 9, 2025
Merged

bevy_winit: Apply #![deny(clippy::allow_attributes, clippy::allow_attributes_without_reason)] #17232

merged 2 commits into from
Jan 9, 2025
+18 −4

Conversation

LikeLakers2
Copy link
Contributor

Objective

Solution

Set the clippy::allow_attributes and clippy::allow_attributes_without_reason lints to deny, and bring bevy_winit in line with the new restrictions.

Testing

cargo clippy --tests was run, and no errors were encountered.

@LikeLakers2 LikeLakers2 mentioned this pull request Jan 8, 2025
Open
8 tasks
@mnmaita mnmaita added C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 8, 2025
@BenjaminBrienen BenjaminBrienen added the A-Windowing Platform-agnostic interface layer to run your app in label Jan 8, 2025
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jan 8, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 9, 2025
Merged via the queue into bevyengine:main with commit 2403487 Jan 9, 2025
28 checks passed
@LikeLakers2 LikeLakers2 deleted the lint/deny_allow_and_without_reason/bevy_winit branch January 9, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnmaita mnmaita mnmaita left review comments

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LikeLakers2 @BenjaminBrienen @mnmaita @alice-i-cecile