extract_shadows responsive coords fix
#17236
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it queries the main world for the camera to get the viewport size for the responsive viewport coords resolution. It should be using the main world camera entity.
ickshonpe
added
C-Bug
pcwalton
approved these changes
Jan 8, 2025
BenjaminBrienen
approved these changes
Jan 8, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
extract_shadowsuses the render world entity corresponding to the extracted camera when it queries the main world for the camera to get the viewport size for the responsive viewport coords resolution and fails. This means that viewport coords get resolved based on a viewport size of zero.Solution
Use the main world camera entity.