Messaging spec #42
Merged
Messaging spec #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekingfrog
force-pushed
the
messaging-spec
branch
from
33052a1 to
61a8ce7
Compare
p2004a
reviewed
Jan 26, 2025
geekingfrog
force-pushed
the
messaging-spec
branch
from
61a8ce7 to
7e7418c
Compare
omg, I forgot the |
p2004a
reviewed
Jan 31, 2025
bcdrme
reviewed
Jan 31, 2025
geekingfrog
force-pushed
the
messaging-spec
branch
from
c4fb91f to
b5a13cc
Compare
* drop the `source` from the subscribe request. Will reintroduce later when it makes sense. * default history mode is `latest` * remove messages from subscribe response * rename `player_id` to `user_id` * add timestamp to messages * change history marker to string. This makes it clearer that it's an opaque value, and give more flexibility to the server.
geekingfrog
force-pushed
the
messaging-spec
branch
from
b5a13cc to
37f837a
Compare
p2004a
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to define the specs for chats. I think we'll add a few other source/target like
lobbyorparty.(also note, the CI on this project does not like jujutsu created commit :/ )