-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cache initialisation under supervision trees #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a really sensible idea; I'll be implementing it in my other projects. Thank you :) |
d217f45
to
eb8717e
Compare
Works on integration server. |
So instantiate this cache first, and setup the initial value where it's required, module by module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the caching logic into logically independent modules, and define supervision tree to start the caches and do initialisation at the same time.
The main benefit is defining a cache and warming it up is now in one place instead of spread across the application.ex and startup.ex files.
One thing to note: some caches are used together. For example
config_site_type_store
and:config_site_cache
are both used by add_site_config_type. In this case, the restart strategy should be:one_for_all
so that if a cache dies, the other is also terminated, and then both are restarted before initialisation.This should be reviewed commit by commit where I tried to only move small bits at a time.
Ultimately I want to straighten up the startup logic which has a bunch of init code outside supervision trees, but that'll come later.
How to test that?
There shouldn't be any functional changes, so:
$help
or$whois