-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tachyon system/serverStats #586
Tachyon system/serverStats #586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny comments.
But you are missing a test for the feature.
You should add a function server_stats
in Support.Tachyon that sends the message and wait for the response. There are plenty of other function doing similar things, list_queues! for example.
Then you should create a new file under test/teiserver_web/tachyon/system_test.exs
, that use TeiserverWeb.ConnCase
.
Then, you can follow the same pattern as the pairing tests to have several user connected.
You can then test that the request returns the correct response, then disconnect a client and try again to see the count updated.
Keep in mind that you’ll need the response schema in the repo as well since the end to end tests are validating the response against the expected schema.
ccff6b9
to
be1ba09
Compare
3fb5513
to
fcccaa7
Compare
fcccaa7
to
991b717
Compare
Completes #561