BarChart 리팩토링 #36
Merged
BarChart 리팩토링 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 종류
어떤 타입의 Pull Request인가요?
현재는 어떻게 동작하나요?
BarChart 내부에 Axis 포함.
각각의 요소를 일반 컴포넌트처럼 css로 배치하기 힘듬
위 방향 그래프 밖에 그릴 수 없음.
이슈 번호: #35
PR이 적용된다면 어떻게 동작하나요?
BarChart에서 Axis 제거
각각의 일반 컴포넌트처럼 css로 배치할 수 있도록 svg 태그로 감쌈.
방향 설정 가능
기타 정보
추후 Animation 대응 등이 필요
Recommend Chart를 만들면서 Bar 부분을 분리할 수 있을지 고민해보기