Add auto-embedding fields #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Coverage report for commit: 379e705 Summary - Lines: 84.58% 🔼 | Methods: 77.71% 🔽
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SergioMendolia
force-pushed
the
add-embedding-fields
branch
from
fa99c3e to
e995b45
Compare
SergioMendolia
force-pushed
the
add-embedding-fields
branch
from
e995b45 to
379e705
Compare
ragusa87
reviewed
Feb 7, 2025
|
|
||
| Unless you want to store embeddings in your database, you can specify `mapped: false` in the configuration, the embeddings will only live in typesense. | ||
|
|
||
| In this case, we recommend to exclude the fields from being retrieved when doing a query as. |
There was a problem hiding this comment.
"In this case, we recommend excluding these fields from being retrieved in the query."
| * 'embed'?:null|FieldMappingEmbedArray, | ||
| * 'mapped'?:bool | ||
| * } | ||
| * @phpstan-type FieldMappingEmbedArray array{ |
There was a problem hiding this comment.
I am hesitating to create an object for this type instead of using an array.
| @@ -197,7 +197,8 @@ public function toArray(): array | |||
| 'synonym_prefix' => $this->synonymPrefix, | |||
| 'text_match_type' => $this->textMatchType, | |||
| 'typo_tokens_threshold' => $this->typoTokensThreshold, | |||
| 'vector_query' => $this->vectorQuery?->toArray(), | |||
| // @phpstan-ignore-next-line (->toArray is part of vectorInterface) | |||
There was a problem hiding this comment.
Don't ignore anything, nothing has been ignored so far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to configure auto embedding fields