Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some package dependencies #287

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Update some package dependencies #287

merged 1 commit into from
Sep 25, 2019

Conversation

future-is-present
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          12       12           
  Lines         309      309           
=======================================
  Hits          294      294           
  Misses         15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba81d1b...a3d1824. Read the comment docs.

@ttmc
Copy link
Contributor

ttmc commented Apr 30, 2019

I see that "version": "4.1.1", is already updated in package.json.

There are probably other things to do when doing a new release, but there doesn't seem to be a "release process" file in this repository listing those things to do. To get a sense of what to consider doing, you might find it helpful to look at the release process file for BigchainDB Server, at:

https://github.com/bigchaindb/bigchaindb/blob/master/RELEASE_PROCESS.md

@ttmc
Copy link
Contributor

ttmc commented May 26, 2019

I'm closing this to make way for doing a new release following the newly-documented release process (documented in #293 ).

@ttmc ttmc closed this May 26, 2019
@ttmc
Copy link
Contributor

ttmc commented May 27, 2019

I looked at what this pull request does and realized that it should probably be reopened, approved, and merged, because it updates some package dependencies. I was thrown off by its title. I will reopen this pull request and change its title.

@ttmc ttmc reopened this May 27, 2019
@ttmc ttmc requested a review from eckelj May 27, 2019 11:12
@ttmc ttmc changed the title Release 4.1.1 Update some package dependencies May 27, 2019
@ttmc
Copy link
Contributor

ttmc commented May 27, 2019

All tests are passing, so that is good!

@eckelj eckelj merged commit d4dae79 into master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants