-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): add number-unlimited column type to worksheet #1621
base: main
Are you sure you want to change the base?
Conversation
|
a25a7cc
to
592480c
Compare
be7dc3a
to
f0b8e07
Compare
Seems weird to me that you can make the cell active and the infinity icon is still present, and you have to manually delete. What happens if you try to edit but leave the ∞ there? Does it fail the validation? I feel like what this is trying to solve is wrong. There should be a checkbox that sets a product as What do you think? |
We tested a prototype of the UX as shown in the video up top with some internal ppl (1 support, 1 sales, 1 customer success, 1 PM not on the backorders team). |
5d0b416
to
608c2fd
Compare
608c2fd
to
1037a9d
Compare
What?
Infinity Icon
.action
prop for columns whose type isnumber
ortext
.Why?
To enable users to add action buttons to these columns.
Screenshots/Screen R
Screen.Recording.2025-01-21.at.15.56.50.mov
Testing/Proof
Unit tests + Locally.