fix: remove msvs_version setup

bigcommerce · Aug 20, 2024 · b45727e · b45727e
1 parent 09957e3
commit b45727e
Show file tree

Hide file tree

Showing 4 changed files with 2,408 additions and 3,418 deletions.
diff --git a/.github/workflows/pull_request_review.yml b/.github/workflows/pull_request_review.yml
@@ -8,8 +8,11 @@ jobs:
     build:
         strategy:
             matrix:
-                node: [22.x]
-                os: ['windows-latest']
+                node: [18.x, 20.x, 22.x]
+                os: ['ubuntu-latest', 'windows-latest', 'macos-latest']
+                exclude:
+                    - os: windows-latest
+                      node: 22.x
         env:
             TITLE: ${{ github.event.pull_request.title }}
 
@@ -28,18 +31,6 @@ jobs:
               with:
                   node-version: ${{ matrix.node }}
 
-            - name: Choco help
-              uses: crazy-max/ghaction-chocolatey@v3
-              with:
-                args: -h
-            - run: choco install visualstudio2019-workload-vctools -y
-
-            - run: echo "; msvs_version=2022" >> ~/.npmrc
-            - run: npm config get msvs_version
-            - run: npm config set msvs_version 2019 --global
-            - run: npm config get msvs_version
-
-            # - run: powershell "npm i -g windows-build-tools"
             - name: Install Dependencies
               run: npm ci
 

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v18.13
+20.16