Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #87

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Improve test coverage #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/idiomorph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,17 +814,14 @@ var Idiomorph = (function () {

/**
*
* @param {Node | null} node1
* @param {Node | null} node2
* @param {Node} node1
* @param {Node} node2
* @param {MorphContext} ctx
* @returns {boolean}
*/
// TODO: The function handles this as if it's Element or null, but the function is called in
// places where the arguments may be just a Node, not an Element
function isIdSetMatch(node1, node2, ctx) {
if (node1 == null || node2 == null) {
return false;
}
if (
node1 instanceof Element &&
node2 instanceof Element &&
Expand Down Expand Up @@ -1044,10 +1041,8 @@ var Idiomorph = (function () {
let htmlElement = content.firstChild;
if (htmlElement) {
generatedByIdiomorph.add(htmlElement);
return htmlElement;
} else {
return null;
}
return htmlElement;
}
} else {
// if it is partial HTML, wrap it in a template tag to provide a parent element and also to help
Expand Down
29 changes: 29 additions & 0 deletions test/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,33 @@ describe("Bootstrap test", function () {
// }, 0)
// print(div1);
});

it("findIdSetMatch rejects morphing node that would lose more IDs", function (done) {
let div1 = make(
'<div id="root1"><div><div id="d1">A</div></div><div><div id="d2">B</div></div><div><div id="d3">C</div></div></div>',
);

let d1 = div1.querySelector("#d1");
let d2 = div1.querySelector("#d2");
let d3 = div1.querySelector("#d3");

let morphTo =
'<div id="root1"><div><div id="d3">F</div></div><div><div id="d1">D</div></div><div><div id="d2">E</div></div></div>';
let div2 = make(morphTo);

print(div1);
Idiomorph.morph(div1, div2);
print(div1);

// first and second paragraph should have morphed
d1.innerHTML.should.equal("D");
d2.innerHTML.should.equal("E");

// third paragrah should have been discarded because it was moved in front of two other paragraphs with ID's
// it should detect that removing the first two nodes with ID's to preserve just one ID is not worth it
d3.innerHTML.should.not.equal("F");

div1.outerHTML.should.equal(morphTo);
done();
});
});
20 changes: 17 additions & 3 deletions test/head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,27 @@ describe("Tests to ensure that the head tag merging works correctly", function (
);
});

it("can handle scripts with block mode", async function () {
it("can handle scripts with block mode with innerHTML morph", async function () {
Idiomorph.morph(
window.document,
`<head><script src='/test/lib/fixture.js'></script></head>`,
{ head: { block: true, style: "append" } },
`<head><script src='/test/lib/fixture.js'></script></head>${window.document.body.outerHTML}`,
{ morphStyle: "innerHTML", head: { block: true, style: "append" } },
);
await waitFor(() => window.hasOwnProperty("fixture"));
window.fixture.should.equal("FIXTURE");
delete(window.fixture);
window.document.head.querySelector('script[src="/test/lib/fixture.js"]').remove();
});

it("can handle scripts with block mode with outerHTML morph", async function () {
Idiomorph.morph(
window.document,
`<html><head><script src='/test/lib/fixture.js'></script></head>${window.document.body.outerHTML}</html>`,
{ morphStyle: "outerHTML", head: { block: true, style: "append" } },
);
await waitFor(() => window.hasOwnProperty("fixture"));
window.fixture.should.equal("FIXTURE");
delete(window.fixture);
window.document.head.querySelector('script[src="/test/lib/fixture.js"]').remove();
});
});
36 changes: 36 additions & 0 deletions test/htmx-integration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,4 +147,40 @@ describe("Tests for the htmx integration", function () {
initialBtn.should.equal(newBtn);
initialBtn.classList.contains("bar").should.equal(true);
});

it("keeps the element stable in an outer morph with oob-swap", function () {
this.server.respondWith(
"GET",
"/test",
"<button id='b1' hx-swap-oob='morph'>Bar</button>",
);
let div = makeForHtmxTest(
"<div hx-get='/test' hx-swap='none'><button id='b1'>Foo</button></div>",
);
let initialBtn = document.getElementById("b1");
div.click();
this.server.respond();
let newBtn = document.getElementById("b1");
initialBtn.should.equal(newBtn);
initialBtn.innerHTML.should.equal("Bar");
});

/* Currently unable to test innerHTML style oob swaps because oob-swap syntax uses a : which conflicts with morph:innerHTML
it("keeps the element stable in an inner morph with oob-swap", function () {
this.server.respondWith(
"GET",
"/test",
"<div id='d1' hx-swap-oob='morph:innerHTML'><button id='b1'>Bar</button></button>",
);
let div = makeForHtmxTest(
"<div id='d1' hx-get='/test' hx-swap='none'><button id='b1'>Foo</button></div>",
);
let initialBtn = document.getElementById("b1");
div.click();
this.server.respond();
let newBtn = document.getElementById("b1");
initialBtn.should.equal(newBtn);
initialBtn.innerHTML.should.equal("Bar");
});
*/
});
Loading