Mesh Editor + improvements + bugfix (replace PR #1154) #1188

digant73 · 2020-10-19T17:46:59Z

NEW FEATURES:

resolves [FR] Ability to edit bed-leveling mesh grid in touch mode #288
resolves Feature: Add button for Marlin Manual Mesh Bed Leveling #594
resolves Showing Mesh on TFT #777
Implemented [FR] Ability to edit bed-leveling mesh grid in touch mode #288 and Showing Mesh on TFT #777 adding a Mesh Editor (under BL menu) and Mesh Tuner menus providing a visual mesh grid (gradient colors are configurable in config.ini) and a fine tune tool for mesh editing. The Mesh Editor supports:

MBL
UBL
ABL Bilinear

BUG FIXES:

Fixed [BUG] MBL problem saving grid on TFT mode #1167 MBL process causing "Invalid mesh" error trying to load the meshes with M420 S1. MBL process is now based on use of standard move gcode
Fixed Duplicate features and icons #967 related to wrong Software Endstops enabling on Probe Offset menu exit. The original Software Endstops state is now restored on menu exit
Fixed [BUG] Use curly braces in if statements. Currently causes dialog to show when it shouldn't #1207

IMPROVEMENTS:

Added new API ProbeHeightControl for Z height fine tuning. The API is used by all the menus providing Z height tuning (e.g. in Probe Offset, MBL, Mesh Editor...)
memory cleanup and various optimization (e.g. in Babystep, ProbeOffset, ABL, PID...)

PR STATE:

FINAL: Ready to be merged with BTT main branch

ETE-Design · 2020-10-19T20:36:37Z

Just tryed to use your PR... But TFT Freeze at "Updating Configuration" Total keywords found: 107... The bar run as it should and then it stops...

TFT/src/User/API/menu.h

digant73 · 2020-10-21T08:04:59Z

Hello digant73.

Could you please close #777 with your PR, thank you.

#777 is reported now as an implemented feature

traffic-light · 2020-10-22T11:29:46Z

Hello digant73.
Could you please close #777 with your PR, thank you.

#777 is reported now as an implemented feature

You need to add close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved in front of the issue to automatically close the issue.

Example: resolves #777

I also got the problem that updating halts after the last keyword... Like @ETE-Design mentioned

digant73 · 2020-10-22T12:00:35Z

@traffic-light ok, done. They are now reported with prefix "resolves"
For the freeze during the configuration update I already asked to the author of flashStore.c to confirm we can set PARA_SIZE to 768 in flashStore.h. The freeze is due to a buffer overflow in flashStore.c caused by the addition of new paramters in config.ini. See the thread in #1167

DominikKnapo · 2020-10-23T10:22:28Z

Hi @digant73, I have compiled your version of code for my Ender 3 Pro running merlin 2, skr mini e3 v2, TFT35 E3.
As I was having issues with Manual Mesh Bed Leveling on the master brench and wanted to try the editor :-).
I did not have mash yet stored in EEPROM as per the mentioned issue. So I have stared the leveling.

Unfortunetly I was not able on any point go below 0.00. Once I have set all points to 0.00, I wa able to edit it in your new editor.

I tried restarting few times but with no luck.

Can you please take a look? Thank You. Maybe it's just me :-).

Nice work on the editor tho!

DK

digant73 · 2020-10-23T12:50:25Z

Hi @digant73, I have compiled your version of code for my Ender 3 Pro running merlin 2, skr mini e3 v2, TFT35 E3.
As I was having issues with Manual Mesh Bed Leveling on the master brench and wanted to try the editor :-).
I did not have mash yet stored in EEPROM as per the mentioned issue. So I have stared the leveling.

Unfortunetly I was not able on any point go below 0.00. Once I have set all points to 0.00, I wa able to edit it in your new editor.

I tried restarting few times but with no luck.

Can you please take a look? Thank You. Maybe it's just me :-).

Nice work on the editor tho!

DK

when you start MBL you should see a notification about software endstops disabled. Did you see that notification? It seems to me that your Marlin FW doesn't allow to disable software endstops, so you cannot set negative Z values

DominikKnapo · 2020-10-23T14:27:47Z

Hi @digant73, I have compiled your version of code for my Ender 3 Pro running merlin 2, skr mini e3 v2, TFT35 E3.
As I was having issues with Manual Mesh Bed Leveling on the master brench and wanted to try the editor :-).
I did not have mash yet stored in EEPROM as per the mentioned issue. So I have stared the leveling.
Unfortunetly I was not able on any point go below 0.00. Once I have set all points to 0.00, I wa able to edit it in your new editor.
I tried restarting few times but with no luck.
Can you please take a look? Thank You. Maybe it's just me :-).
Nice work on the editor tho!
DK

when you start MBL you should see a notification about software endstops disabled. Did you see that notification? It seems to me that your Marlin FW doesn't allow to disable software endstops, so you cannot set negative Z values

Thank you for your reply.

I do not see the notification, but I'm able to use commands M211 S0/S1, which if I'm not mistaken should disable/enable the software endstops, I can confirm that I was able to switch them ON/OFF.

Is there maybe something I'm missing?

DK

digant73 · 2020-10-23T15:15:46Z

@DominikKnapo No, it's correct. With Z offset menu are you able to move the nozzle to negative values? The same API is used by Z offset and MBL. However I will check it this night

DominikKnapo · 2020-10-23T16:52:45Z

@DominikKnapo No, it's correct. With Z offset menu are you able to move the nozzle to negative values? The same API is used by Z offset and MBL. However I will check it this night

The Z offset menu is not working for me properly, wrong command M851, but I guess that's a different issue. When I get into the menu I can see the notification about disabling software endstops.

I have also tried manually disabling the software endstops and running manual mesh bed leveling, this was working for me.

Best regards,

DK

…software endstops during MBL process

…EETECH-TouchScreenFirmware into bugfix-2020-10-19

digant73 · 2020-10-23T18:11:09Z

@DominikKnapo No, it's correct. With Z offset menu are you able to move the nozzle to negative values? The same API is used by Z offset and MBL. However I will check it this night

The Z offset menu is not working for me properly, wrong command M851, but I guess that's a different issue. When I get into the menu I can see the notification about disabling software endstops.

I have also tried manually disabling the software endstops and running manual mesh bed leveling, this was working for me.

Best regards,

DK

ok, it seems your Marlin FW doesn't automatically disable software endstops when MBL process is started. I restored also for MBL the software endstops disabling. Now it should work also for your Marlin FW. Please, try with the new version and let me know it works properly.
Which version of Marlin FW are you using? At least until version 2.0.6.1 enstops were disabled automatically during MBL

Guilouz · 2020-10-23T22:28:01Z

Just try you PR, when we launch mesh edit, notification popup for software endstop is cutted vertically at the top of the screen.

And what do you think about that for the arrows ?

digant73 · 2020-10-24T07:49:14Z

@Guilouz For the notification it's not a problem. I mean, there is an overlap (it's not a bug I can fix in my code) only when the custom mesh editor menu is displayed the first time. After that all the notifications are displayed correctly and then the mesh editor menu is redrawn correctly.
For the arrows, yes they are the solution I also preferred but I didn't found the code (in the pre defined codes) for the up and down arrows. Which values did you use, so I will apply those in the PR?

Guilouz · 2020-10-24T10:42:01Z

@Guilouz For the notification it's not a problem. I mean, there is an overlap (it's not a bug I can fix in my code) only when the custom mesh editor menu is displayed the first time. After that all the notifications are displayed correctly and then the mesh editor menu is redrawn correctly.
For the arrows, yes they are the solution I also preferred but I didn't found the code (in the pre defined codes) for the up and down arrows. Which values did you use, so I will apply those in the PR?

I use this :

const char *const meshKeyString[MESH_KEY_NUM] = {
"", // SAVE
"\u0894", // OK
"\u08A5", // RESET
"", // HOME
"", // EDIT
"˄", // UP
"˂", // PREV
"˃", // NEXT
"˅", // DOWN
};

Mactastic1-5 · 2020-10-26T03:14:23Z

Does the microSD card work for you?

digant73 · 2020-10-26T08:41:53Z

@stellarspace yes it perfectly works. try to reformat the sd card

DominikKnapo · 2020-10-27T12:51:42Z

@DominikKnapo No, it's correct. With Z offset menu are you able to move the nozzle to negative values? The same API is used by Z offset and MBL. However I will check it this night

The Z offset menu is not working for me properly, wrong command M851, but I guess that's a different issue. When I get into the menu I can see the notification about disabling software endstops.
I have also tried manually disabling the software endstops and running manual mesh bed leveling, this was working for me.
Best regards,
DK

ok, it seems your Marlin FW doesn't automatically disable software endstops when MBL process is started. I restored also for MBL the software endstops disabling. Now it should work also for your Marlin FW. Please, try with the new version and let me know it works properly.
Which version of Marlin FW are you using? At least until version 2.0.6.1 enstops were disabled automatically during MBL

Hi, @digant73 sorry for late response.
I'm using latest marlin firmware. It now seems that it is working.
Thank you so much!

DK

…EETECH-TouchScreenFirmware into bugfix-2020-10-19

oldman4U · 2020-10-27T15:32:41Z

It seems that there are some requirements related to Marlin settings to make this work. Will you mention them somewhere? Dominik Knapo <[email protected]> schrieb am Di. 27. Okt. 2020 um 13:51:

…

@DominikKnapo <https://github.com/DominikKnapo> No, it's correct. With Z offset menu are you able to move the nozzle to negative values? The same API is used by Z offset and MBL. However I will check it this night The Z offset menu is not working for me properly, wrong command M851, but I guess that's a different issue. When I get into the menu I can see the notification about disabling software endstops. I have also tried manually disabling the software endstops and running manual mesh bed leveling, this was working for me. Best regards, DK ok, it seems your Marlin FW doesn't automatically disable software endstops when MBL process is started. I restored also for MBL the software endstops disabling. Now it should work also for your Marlin FW. Please, try with the new version and let me know it works properly. Which version of Marlin FW are you using? At least until version 2.0.6.1 enstops were disabled automatically during MBL Hi, @digant73 <https://github.com/digant73> sorry for late response. I'm using latest marlin firmware. It now seems that it is working. Thank you so much! DK — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1188 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM6XKZFYWSLOYCKS3D3AK6DSM2665ANCNFSM4SWOZHUA> .

digant73 · 2020-10-27T16:12:31Z

@oldman4U I think that from Marlin 2.0.7.x they changed some specification for MBL. Software endstops must be now manually disabled before performing MBL process. Until 2.0.6.1 MBL didn't require to manually disable software endstops (and for me it had more sense). In Marlin 2.0.7.2 a lot of changes were made compared to 2.0.6.1

oldman4U · 2020-10-27T16:15:04Z

So it would be great to define a minimum Marlin version and the settings which have to be (de)activated and the value of those settings. digant73 <[email protected]> schrieb am Di. 27. Okt. 2020 um 17:12:

…

@oldman4U <https://github.com/oldman4U> I think that from Marlin 2.0.7.x they changed some specification for MBL. Software endstops must be now manually disabled before performing MBL process. Until 2.0.6.1 MBL didn't require to manually disable software endstops (and for me it had more sense). In Marlin 2.0.7.2 a lot of changes were made compared to 2.0.6.1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1188 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM6XKZFJGVHLRUKQNZRIG43SM3WQFANCNFSM4SWOZHUA> .

digant73 · 2020-10-27T16:17:48Z

@oldman4U I would say it is not needed. I simply disable software endstops also for MBL (not only for Z probe and Mesh editor). With "manually disabled" I meant I provided the instruction to disable the software endstops, not that the user must be aware of that and must perform that by himself.
With that addition (always disable software endstops before MBL process), MBL is compliant to all Marlin versions. Already tested and working (as also reported by Dominik)

oldman4U · 2020-10-27T16:51:26Z

Perfect!

Thank you

…EETECH-TouchScreenFirmware into bugfix-2020-10-19 # Conflicts: # Copy to SD Card root directory to update - Unified Menu Material theme/Language Packs/language_it.ini # Copy to SD Card root directory to update/Language Packs/language_it.ini # TFT/src/User/Language Packs/language_it.ini

…gtreetech#1188) * minor fix for a bug causing a freeze during configuration update * fixed bug on MBL menu for some Marlin FW not automatically disabling software endstops during MBL process * updated UP, DOWN, LEFT and RIGHT symbols

Merge with BTT main branch

8f45b72

digant73 changed the title ~~Mesh Editor + improvements + bugfix~~ Mesh Editor + improvements + bugfix (replace PR #1154) Oct 19, 2020

guruathwal reviewed Oct 20, 2020

View reviewed changes

TFT/src/User/API/menu.h Show resolved Hide resolved

oldman4U mentioned this pull request Oct 20, 2020

[BUG] MBL problem saving grid on TFT mode #1167

Closed

oldman4U mentioned this pull request Oct 23, 2020

[BUG] Z-Offset ABL crashes gantry #1183

Closed

digant73 and others added 2 commits October 23, 2020 10:24

minor fix for a bug causing a freeze during configuration update

fdfe6c6

Merge branch 'master' into bugfix-2020-10-19

aa84f37

digant73 added 2 commits October 23, 2020 20:01

fixed bug on MBL menu for some Marlin FW not automatically disabling …

55580b4

…software endstops during MBL process

Merge branch 'bugfix-2020-10-19' of https://github.com/digant73/BIGTR…

987bac9

…EETECH-TouchScreenFirmware into bugfix-2020-10-19

digant73 added 3 commits October 24, 2020 17:03

updated UP, DOWN, LEFT and RIGHT symbols

da12ae7

cleanup

bf074aa

updated language pack

6fc1bf7

Mactastic1-5 mentioned this pull request Oct 26, 2020

[BUG] TFT goto previous screen when 32 GB microSD is selected #1208

Closed

digant73 added 2 commits October 26, 2020 15:14

fixed bug bigtreetech#1207

34cb863

merge with BTT main branch

e340138

Merge branch 'master' into bugfix-2020-10-19

1d001b8

digant73 added 3 commits October 27, 2020 14:58

minor cleanup

67f2344

Merge branch 'bugfix-2020-10-19' of https://github.com/digant73/BIGTR…

533f62e

…EETECH-TouchScreenFirmware into bugfix-2020-10-19

merge with BTT main branch

c242fa2

bigtreetech and others added 3 commits October 28, 2020 14:15

Merge branch 'master' into bugfix-2020-10-19

a9d4abe

merge with BTT main branch

31841eb

bigtreetech merged commit df413fc into bigtreetech:master Oct 28, 2020

NicoletoAerials mentioned this pull request Oct 28, 2020

Latest Master is not working with the SKR TFT35 V3.0 #1213

Closed

amp-man mentioned this pull request Nov 5, 2020

Add support for Home Offset #1198

Merged

digant73 deleted the bugfix-2020-10-19 branch May 31, 2021 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mesh Editor + improvements + bugfix (replace PR #1154) #1188

Mesh Editor + improvements + bugfix (replace PR #1154) #1188

digant73 commented Oct 19, 2020 •

edited

Loading

ETE-Design commented Oct 19, 2020

digant73 commented Oct 21, 2020 •

edited

Loading

traffic-light commented Oct 22, 2020 •

edited

Loading

digant73 commented Oct 22, 2020 •

edited

Loading

DominikKnapo commented Oct 23, 2020

digant73 commented Oct 23, 2020

DominikKnapo commented Oct 23, 2020

digant73 commented Oct 23, 2020

DominikKnapo commented Oct 23, 2020 •

edited

Loading

digant73 commented Oct 23, 2020 •

edited

Loading

Guilouz commented Oct 23, 2020 •

edited

Loading

digant73 commented Oct 24, 2020 •

edited

Loading

Guilouz commented Oct 24, 2020 •

edited

Loading

Mactastic1-5 commented Oct 26, 2020

digant73 commented Oct 26, 2020

DominikKnapo commented Oct 27, 2020

oldman4U commented Oct 27, 2020 via email

digant73 commented Oct 27, 2020

oldman4U commented Oct 27, 2020 via email

digant73 commented Oct 27, 2020 •

edited

Loading

oldman4U commented Oct 27, 2020

Mesh Editor + improvements + bugfix (replace PR #1154) #1188

Mesh Editor + improvements + bugfix (replace PR #1154) #1188

Conversation

digant73 commented Oct 19, 2020 • edited Loading

ETE-Design commented Oct 19, 2020

digant73 commented Oct 21, 2020 • edited Loading

traffic-light commented Oct 22, 2020 • edited Loading

digant73 commented Oct 22, 2020 • edited Loading

DominikKnapo commented Oct 23, 2020

digant73 commented Oct 23, 2020

DominikKnapo commented Oct 23, 2020

digant73 commented Oct 23, 2020

DominikKnapo commented Oct 23, 2020 • edited Loading

digant73 commented Oct 23, 2020 • edited Loading

Guilouz commented Oct 23, 2020 • edited Loading

digant73 commented Oct 24, 2020 • edited Loading

Guilouz commented Oct 24, 2020 • edited Loading

Mactastic1-5 commented Oct 26, 2020

digant73 commented Oct 26, 2020

DominikKnapo commented Oct 27, 2020

oldman4U commented Oct 27, 2020 via email

digant73 commented Oct 27, 2020

oldman4U commented Oct 27, 2020 via email

digant73 commented Oct 27, 2020 • edited Loading

oldman4U commented Oct 27, 2020

digant73 commented Oct 19, 2020 •

edited

Loading

digant73 commented Oct 21, 2020 •

edited

Loading

traffic-light commented Oct 22, 2020 •

edited

Loading

digant73 commented Oct 22, 2020 •

edited

Loading

DominikKnapo commented Oct 23, 2020 •

edited

Loading

digant73 commented Oct 23, 2020 •

edited

Loading

Guilouz commented Oct 23, 2020 •

edited

Loading

digant73 commented Oct 24, 2020 •

edited

Loading

Guilouz commented Oct 24, 2020 •

edited

Loading

digant73 commented Oct 27, 2020 •

edited

Loading