Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Z Steppers Auto-Alignment (G34) #1483

Merged
merged 6 commits into from
Jan 12, 2021
Merged

Add Z Steppers Auto-Alignment (G34) #1483

merged 6 commits into from
Jan 12, 2021

Conversation

Guilouz
Copy link
Contributor

@Guilouz Guilouz commented Jan 5, 2021

Enable/Disable via config.ini
Disabled by default.

Resolve #1150

Enable/Disable via config.ini
Disable by default
@ETE-Design
Copy link

Great to see this feature implemented :-) Is it possible direct from the display to tell where on the bed it should meassure?

@Guilouz
Copy link
Contributor Author

Guilouz commented Jan 5, 2021

Great to see this feature implemented :-) Is it possible direct from the display to tell where on the bed it should meassure?

Not easy because XY positions for mesure also depend on the offset of the bltouch, i don't know what a bad value can do but one thing is certain is that at compilation if the values ​​are not correct it falls into error

The best way is to use probe limits by default in Marlin.

@ETE-Design
Copy link

ETE-Design commented Jan 5, 2021

@Guilouz Not a big deal, but was just so people don't have to flash Marlin a coulpe of times of they don't know the exact meassure point they want to use from the start.

@Guilouz
Copy link
Contributor Author

Guilouz commented Jan 6, 2021

@Guilouz Not a big deal, but was just so people don't have to flash Marlin a coulpe of times of they don't know the exact meassure point they want to use from the start.

No needed to flash Marlin every time just enable #define Z_STEPPER_ALIGN_XY in Marlin and use M422 command to adjust https://marlinfw.org/docs/gcode/M422.html

@radek8
Copy link
Contributor

radek8 commented Jan 6, 2021

After all, it is not a problem to set these values in the Parametersetting.c menu
Just know what format the data should be.

@ETE-Design
Copy link

ETE-Design commented Jan 6, 2021

@Guilouz / @radek8 Mabye make 2 value boxes for each side, to input x/y values, a button to each named check so it places the sensor over each point... Then a save Button to save the values...

@radek8
Copy link
Contributor

radek8 commented Jan 6, 2021

If you have 2 stepper motors on the Z axis,
can you enter the answer to commsnd here?
M503
M422

@Guilouz
Copy link
Contributor Author

Guilouz commented Jan 6, 2021

If you have 2 stepper motors on the Z axis,
can you enter the answer to commsnd here?
M503
M422

No there is no M422 command with M503 report, I try it

It quickly becomes hellish because Marlin allows up to 4 steppers Z1, Z2, Z3 and Z4 with each X and Y coordinates for this function and since it's a feature that not everyone can use (one Z stepper or double stepper on same driver or no bltouch), I did not complicate myself.

@radek8
Copy link
Contributor

radek8 commented Jan 6, 2021

You're right.
Therefore, once the sensor points are defined, there is no need to change it.

Copy link
Contributor Author

@Guilouz Guilouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update flashStore.c

@Guilouz
Copy link
Contributor Author

Guilouz commented Jan 7, 2021

@bigtreetech Can you merge it please ?

@bigtreetech bigtreetech merged commit 4ae57ff into bigtreetech:master Jan 12, 2021
Uz45 added a commit to Uz45/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jan 15, 2021
Auto detect Firmware Type bigtreetech#1507
Fix filenames to work on TFT24 to reset settings after firmware was updated bigtreetech#1499
Add Menu TouchMI bigtreetech#1496
Implemet Print from SD-Crd for RepRapFirmware bigtreetech#1495
Enhanced italian language bigtreetech#1490
Onboard SD print - Long filename; TFT aware of other printing host bigtreetech#1488
Standard deviation - BLTouch repeatability test bigtreetech#1484
Add Z Steppers Auto-Alignment (G34) bigtreetech#1483
Updated ReadMe bigtreetech#1475
jeffeb3 pushed a commit to V1EngineeringInc/BIGTREETECH-TouchScreenFirmware that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include G34 Auto-Alignment to Movement/BedLevel UI
5 participants