Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SODAR Core v0.10 #77

Merged
merged 13 commits into from
Apr 21, 2022
Merged

Upgrade to SODAR Core v0.10 #77

merged 13 commits into from
Apr 21, 2022

Conversation

mikkonie
Copy link
Contributor

@mikkonie mikkonie commented Mar 10, 2022

This pull request upgrades Digestiflow for the latest release of SODAR Core. This fixes many bugs, upgrades numerous dependencies to current secure versions and allows us to more easily integrate bug fixes in the future.

This PR also contains the changes to remove the broken legacy tokens app which don't appear to have been merged yet.

I'd be happy of someone could test this out locally and let me know if I've made any mistakes or missed any issues.

How to Try Out Locally

(This assumes you already have a local dev copy with a database created etc)

  • Create and activate new venv with Python 3.8 or above. Python 3.7 and below are no longer supported.
  • Install requirements from requirements/local.txt and requirements/test.txt.
  • Run the following commands in this order:
    • ./manage.py migrate
    • ./manage.py geticons
    • ./manage.py collectstatic

Notes

  • When upgrading icons to use Iconify, I took the liberty to update the icon set from FA4 to MDI.
    • I first simply updated existing icons to use FA4 via Iconify, but using two different icon sets looked VERY confusing.
    • If you disagree with any or all of my icon choices, feel free to change ;)
  • Someone with more knowledge of CentOS might want to update the install docs for Python v3.8+. Do we still need to support CentOS somewhere?
  • When the Django Debug Toolbar is enabled, there's a warning when running the server. This seems to be a bug in the toolbar itself, since the related TEMPLATES setting is set up in the appropriate way. Unless I'm missing something?
  • Tests run successfully. Flake8 fails, but only with errors which were there before I forked ;)
  • I didn't touch CI yet, since it seems to use some ancient Travis setup. If needed, I'd be happy to get this running with GitHub Actions. Let me know how to handle this.
  • There may be some problems with the pagerange package. Not sure why it's needed.
  • I also fixed some requirements problems while I was at it. Never include django-extensions in production! It is not "needed for collecstatic".
  • I warmly recommend squashing the commits when merging, as I did this in multiple commits due to complexity and many subtasks.

@mikkonie mikkonie linked an issue Mar 10, 2022 that may be closed by this pull request
15 tasks
@mikkonie
Copy link
Contributor Author

Now up in staging, please let me know if something breaks or doesn't look right.

@mikkonie
Copy link
Contributor Author

Update: Since I just tagged SODAR Core v0.10.11, updated this PR to the latest version. I also used the new sidebar icon resizing feature to make the icons a bit smaller, meaning the sidebar won't disappear so easily on lower resolutions, especially for admin users.

@messersc messersc merged commit 197a971 into main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to SODAR Core v0.10
2 participants