Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add screen cast with pipewire example #247

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

SyedAhkam
Copy link
Contributor

@SyedAhkam SyedAhkam commented Nov 18, 2024

fixes: #155

examples/screen_cast_pw.rs Outdated Show resolved Hide resolved
examples/screen_cast_pw.rs Show resolved Hide resolved
examples/screen_cast_pw.rs Outdated Show resolved Hide resolved
examples/screen_cast_pw.rs Outdated Show resolved Hide resolved
examples/screen_cast_pw.rs Outdated Show resolved Hide resolved
@bilelmoussaoui
Copy link
Owner

I asked someone with pipewire knowledge if they can review it. If I don't hear anything by the weekend, will merge.

Would you mind adding a comment in the docs of both the camera/screencast portal pointing to this example?

@bilelmoussaoui
Copy link
Owner

And ignore the datas typo in https://github.com/bilelmoussaoui/ashpd/blob/master/.typos.toml

README.md Outdated Show resolved Hide resolved
@SyedAhkam
Copy link
Contributor Author

All done, lets wait for your friend now.

@SyedAhkam
Copy link
Contributor Author

SyedAhkam commented Nov 18, 2024

not sure why are tests failing even though I used ```rust,no_run

gotta use ignore

Copy link

@rmader rmader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look over the PW parts - only one comment, the rest look sensible to me

examples/screen_cast_pw.rs Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@bilelmoussaoui bilelmoussaoui merged commit 80fac9e into bilelmoussaoui:master Nov 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grabbing frames from the PipeWire stream isn't explained.
4 participants