update AppCompatProgressBarHelper getColorStateList by ThemeUtil getT… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyczero
reviewed
Oct 18, 2017
| @@ -56,11 +56,15 @@ void loadFromAttribute(AttributeSet attrs, int defStyleAttr) { | |||
| TypedArray array = mView.getContext().obtainStyledAttributes(attrs, ATTR, defStyleAttr, 0); | |||
| if (array.hasValue(0)) { | |||
| mProgressTintResId = array.getResourceId(0, 0); | |||
| setSupportProgressTint(array.getColorStateList(0)); | |||
| if (mProgressTintResId != 0) { | |||
There was a problem hiding this comment.
已经判断了hasValue，mProgressTintResId理应不会为0
| @@ -141,10 +145,10 @@ private Drawable getTintTarget(int layerId, boolean shouldFallback) { | |||
| @Override | |||
| public void tint() { | |||
| if (mProgressTintResId != 0) { | |||
| setSupportProgressTint(mView.getResources().getColorStateList(mProgressTintResId)); | |||
| setSupportProgressTint(ThemeUtils.getThemeColorStateList(mView.getContext(), mProgressTintResId)); | |||
There was a problem hiding this comment.
在setSupportIndeterminateTint函数中有对mProgressTintResId的颜色值进行转换，目前只取getDefaultColor作为染色值
There was a problem hiding this comment.
setSupportIndeterminateTint 中是通过ThemeUtils.getColor（）替换color int 的值， 最终体现在replaceColor(Context context, @ColorInt int color)这个方法里面， 而我更希望更多的通过color id替换color的值，也就是replaceColorById(Context context, @ColorRes int colorId)。因为我总感觉替换replaceColor的方法不可靠， replaceColorById更加可靠， 万一有两个color id， 但是两个color id的颜色值都一样，这样的情况下就会出问题。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hemeColorStateList
#36