Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEC Bug fixes #162

Merged
merged 11 commits into from
Mar 18, 2021
Merged

AEC Bug fixes #162

merged 11 commits into from
Mar 18, 2021

Conversation

angelhof
Copy link
Member

No description provided.

@angelhof angelhof changed the title [DRAFT] AEC Bug fixes AEC Bug fixes Mar 17, 2021
@angelhof angelhof marked this pull request as ready for review March 17, 2021 14:26
@angelhof angelhof requested a review from nvasilakis March 18, 2021 16:03
@angelhof
Copy link
Member Author

@nvasilakis feel free to take a look (no need to though) and merge when you are ready :)

@@ -12,7 +12,7 @@ while getopts 'slh' opt; do
case $opt in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename here contains dish:-)

@@ -0,0 +1,190 @@
Arguments:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure we need these in the repo, but I'll leave the final decision up to you:-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we need to have a discussion about this, for now this should OK.

@angelhof angelhof merged commit e5f56ec into main Mar 18, 2021
@angelhof angelhof deleted the aec-b-bug-fixes branch March 31, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants