Upgrade CI to latest OS versions #746
Merged
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bolun Thompson <[email protected]>
|
OS = |
|
OS:ubuntu-20.04 |
|
This is independent from #737. It could be merged at the same time as #745 (or afterwards) if you think it’d be fine to switch docker to 24.04 simultaneously (although in hindsight we could just choose to push a new docker image later on if pash seems to work with ubuntu 24.04 — it works locally, at least). |
|
I am not sure there is any dependency, but I would like to merge this after #737 so that we make sure that passes first (I don't want to keep it lingering for long :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate from #745 in case we want to wait and see if it causes any problems.
Separately, the docker containers are a bit out of date (last pushed May 2023), so could whoever has permissions to update those push the new version? (although I’m not sure how important those are to keep up to date).