Fail if Custom Resource can't connect to Database #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which is also default for TCP connections
bogdankatishev
added a commit
to vrtdev/custom-resources
that referenced
this pull request
May 11, 2022
Till upstream PR gets merged: binxio/cfn-mysql-user-provider#13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this old "closed" issue: #6
To avoid waiting/hanging for a hour till cloudformation stops the update/delete itself.
In cloudformation, you will get this output
This will then trigger a ROLLBACK_IN_PROGRESS and then ROLLBACK_COMPLETE, all under 1 minute.