Find unique user based on lowercase email compare #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple users are found, do email check case-insensitive. Also when not found, log the found email address as a set.
|
Note I did this "coding" online github editor, without any checks. I hope you have proper tests ;) |
mvanholsteijn
approved these changes
Jan 15, 2025
| @@ -338,11 +338,12 @@ def get_unique_user_by_name(self, name: str, email: Optional[str]) -> "User": | |||
| if len(users) == 0: | |||
| raise ValueError(f"author '{name}' not found on {self.endpoint.host}") | |||
| elif len(users) > 1: | |||
| user = next(filter(lambda u: email and u.email == email, users), None) | |||
| user = next(filter(lambda u: email and u.email.lower() == email.lower(), users), None) | |||
There was a problem hiding this comment.
if u.email is none, this will throw an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple users are found, do email check case-insensitive.
In case the email does not match, log the found email address as a set.
Return the user which matches the email address instead of the first in the list.
Fix for #11