Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append all split FASTA files to the list for TRF execution #45

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

weichisyu
Copy link
Contributor

@weichisyu weichisyu commented Dec 24, 2024

We welcome feedback and issue reporting for all bioBakery tools through our Discourse site. For users that would like to directly contribute to the tools we are happy to field PRs to address bug fixes. Please note the turn around time on our end might be a bit long to field these but that does not mean we don't value the contribution! We currently don't accept PRs to add new functionality to tools but we would be happy to receive your feedback on Discourse.

Also, we will make sure to attribute your contribution in our User’s manual(README.md) and in any associated paper Acknowledgements.

Description

The size of the output FASTQ file is different when the -t argument is greater then 1.
I found that it might be caused by line 124 in kneaddata/trf_parallel.py
Since file_handle_write is always not None after the file is opened(line 124), only the first temporary file is appended to the tempfile_written_list and datfile_to_write_list(line 115~116). As a result, the trf command actually executes only one parallel temporary file.

Related Issue

Screenshots (if appropriate):

@sagun98 sagun98 merged commit e094045 into biobakery:master Feb 5, 2025
@sagun98
Copy link
Contributor

sagun98 commented Feb 5, 2025

Hi @weichisyu ,
Thank you for reaching out to the bioBakery Lab and pointing out the “TRF parallel run” issue + fix. I have added your email and username in the Contribution section of Kneaddata User’s Manual Here: https://github.com/biobakery/kneaddata/blob/master/readme.md#contributions. Please let me know if you would like to change any of your information listed here. Thank you again.

@weichisyu
Copy link
Contributor Author

weichisyu commented Feb 6, 2025

Hi @sagun98,
Thank you for reviewing and accepting my PR! I appreciate it.
The information looks correct, and no changes are needed at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants