Update blast: drop blast phone-home patch

[jchorl]

The current phone-home disabling patch of blast actually breaks it in many cases.

I opened an issue here: #53165

Without diving into whether the existing patch is a good idea, it is breaking the functionality of the package.

I did try a different patch to disable phoning home:

diff --git a/c++/src/algo/blast/api/blast_usage_report.cpp b/c++/src/algo/blast/api/blast_usage_report.cpp
index c6ffc31..b5ab985 100644
--- a/c++/src/algo/blast/api/blast_usage_report.cpp
+++ b/c++/src/algo/blast/api/blast_usage_report.cpp
@@ -211,9 +211,9 @@ void CBlastUsageReport::x_CheckBlastUsageEnv()
                        return ;
                }
        }
-       CUsageReportAPI::SetEnabled(true);
-       SetEnabled(true);
-       LOG_POST(Info <<"Phone home enabled");
+       // CUsageReportAPI::SetEnabled(true);
+       // SetEnabled(true);
+       // LOG_POST(Info <<"Phone home enabled");
 }
 
 void CBlastUsageReport::AddParam(EUsageParams p, Int8 val)

Even with that patch:

terminate called after throwing an instance of 'ncbi::CCoreException'
  what():  NCBI C++ Exception:
    T1 "/opt/conda/conda-bld/blast_1736524853502/work/c++/src/corelib/ncbiobj.cpp", line 1010: Critical: (CCoreException::eNullPtr) ncbi::CObject::ThrowNullPointerException() - Attempt to access NULL pointer.
     Stack trace:
      /opt/conda/bin/../lib/ncbi-blast+/libxncbi.so ???:0 ncbi::CObject::ThrowNullPointerException() offset=0xC1 addr=0x743b746e91d1
      /opt/conda/bin/../lib/ncbi-blast+/libxblast.so ???:0 ncbi::blast::CBlastNode::~CBlastNode() offset=0x36D addr=0x743b7645817d
      blastn ???:0 ncbi::blast::CBlastnNode::~CBlastnNode() offset=0xA addr=0x56af3b6449ea
      /opt/conda/bin/../lib/ncbi-blast+/libxncbi.so ???:0 ncbi::CThread::Wrapper(void*) offset=0x1B6 addr=0x743b74722a96
      /lib/x86_64-linux-gnu/libc.so.6 ???:0  offset=0x891C4 addr=0x743b7430c1c4
      /lib/x86_64-linux-gnu/libc.so.6 ???:0 __clone offset=0x40 addr=0x743b7438bac0

This too breaks the functionality. The issue seems to be that blast binaries rely on the concurrency controls in usage-reporting in order to shut down safely. Disabling it must be done with care as to not break the core functionality.

With that said, could we first prioritize making the core functionality work, and then find a way to disable this functionality if we can adequately resource it? I've spent some time investigating but it's quite complex.

---

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

• If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
• New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
• PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
• Please post questions on Gitter or ping @bioconda/core in a comment.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update	Merge the master branch into a PR.
@BiocondaBot please add label	Add the please review & merge label.
@BiocondaBot please fetch artifacts	Post links to CI-built packages/containers. You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.