Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get started with new S3 collection backend #1

Merged
merged 9 commits into from
Feb 21, 2024
Merged

Get started with new S3 collection backend #1

merged 9 commits into from
Feb 21, 2024

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Feb 19, 2024

No description provided.

@FynnBe FynnBe requested a review from jmetz February 19, 2024 08:43
@jmetz
Copy link
Contributor

jmetz commented Feb 19, 2024

@FynnBe : Ready for me to merge or you wanna keep working on some part of this?

jmetz
jmetz approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@jmetz jmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I know there's more planned in another PR IIUC

@jmetz jmetz marked this pull request as draft February 19, 2024 13:34
@FynnBe FynnBe marked this pull request as ready for review February 21, 2024 13:01
@FynnBe FynnBe merged commit d185c34 into main Feb 21, 2024
@FynnBe FynnBe deleted the get_started branch February 22, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmetz jmetz jmetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FynnBe @jmetz