Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the CIs for Icy and deepImageJ using JDLL #82

Draft
wants to merge 152 commits into
base: main
Choose a base branch
from

Conversation

carlosuc3m
Copy link
Member

No description provided.

@carlosuc3m
Copy link
Member Author

Hello @FynnBe this is the CI for deepimagej, exclusively.
I am now doing two separate CIs for deepimagej and deepicy testing the actual software instead of just the backend (JDLL). In my opinion, now the CI mimics the reality better.

Please, if you can, have a look at the generated reports to see if they are what it is needed:
https://github.com/carlosuc3m/collection/actions/runs/13031819471
https://github.com/carlosuc3m/collection/actions/runs/13031819471/artifacts/2504412013

As expected, dij only has issues with pytorch_state_dict models.

The only thing remaining to do is to check why are there some models that produce an output different to the expected one. Once that is fixed it should be ready to be merged. Then I can do another pull request for the Icy CI, or would you rather have both of them together?

This CI only checks for published models, should it check draft models too?

REgards,
Carlos

@FynnBe
Copy link
Member

FynnBe commented Feb 7, 2025

Hello @FynnBe this is the CI for deepimagej, exclusively. I am now doing two separate CIs for deepimagej and deepicy testing the actual software instead of just the backend (JDLL). In my opinion, now the CI mimics the reality better.

awesome 👍

Please, if you can, have a look at the generated reports to see if they are what it is needed: https://github.com/carlosuc3m/collection/actions/runs/13031819471 https://github.com/carlosuc3m/collection/actions/runs/13031819471/artifacts/2504412013

looks great! 👍

The only thing remaining to do is to check why are there some models that produce an output different to the expected one. Once that is fixed it should be ready to be merged.

yeah.. I'm currently working on an update to spec to set more generous default tolerances. This is probably something you'd want to check in the JDLL, too then...

Then I can do another pull request for the Icy CI, or would you rather have both of them together?

no, separate is even better 👍

This CI only checks for published models, should it check draft models too?

no, published only is good

@carlosuc3m
Copy link
Member Author

Hello again @FynnBe

yeah.. I'm currently working on an update to spec to set more generous default tolerances. This is probably something you'd want to check in the JDLL, too then...

Should i just increase the tolerances to let them pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants