Make biscuit_auth module init function pub #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have python bindings to both the stock biscuit-auth crate, as well as our own rust crate that depends on biscuit-auth. In order for these to interoperate they all need to be linked together into a single shared library. (Or at least, that was the safest way I could find to do it). AFAICT python requires that the shared library name match the module name, so it will not call the module init function in this case. This PR makes the `biscuit_auth` module init function `pub` so it can be called from another crate's module init function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have python bindings to both the stock biscuit-auth crate, as well
as our own rust crate that depends on biscuit-auth. In order for
these to interoperate they all need to be linked together into a
single shared library. (Or at least, that was the safest way I could
find to do it).
AFAICT python requires that the shared library name match the module
name, so it will not call the module init function in this case. This
PR makes the
biscuit_authmodule init functionpubso it can becalled from another crate's module init function.