generated from mrz1836/go-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-1419): manage contacts flow example with proper TOTP generation & validation #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual Tests💚 Manual testing by @chris-4chain resulted in success. |
dzolt-4chain
approved these changes
Jan 29, 2025
pawellewandowski98
approved these changes
Jan 29, 2025
chris-4chain
requested changes
Jan 29, 2025
chris-4chain
approved these changes
Jan 30, 2025
Co-authored-by: chris-4chain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Any new significant addition
regression-tests
Runs regression tests
tested
PR was tested by a team member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the TOTP generation and validation functionality, along with the addition of a new task for managing contacts. The most important changes include the removal of the old
generate_totp
task, the introduction of a newmanage_contacts
task, and updates to the TOTP validation method to improve clarity and functionality.Task Management Changes:
generate_totp
task fromexamples/Taskfile.yml
.manage_contacts
task toexamples/Taskfile.yml
for demonstrating TOTP generation and validation scenarios.Codebase Updates:
generate_totp.go
file, which contained the previous TOTP generation logic.manage_contacts.go
file, which includes a comprehensive example of managing contacts and TOTP verification between users. This file introduces new configuration structures, user setup, and verification flow functions.TOTP Validation Improvements:
ValidateTotpForContact
method ininternal/api/v1/user/totp/totp.go
to rename parameters for better clarity, changingrequesterPaymail
tovalidatorContact
.ValidateTotpForContact
method inuser_api.go
to reflect the same parameter renaming for consistency and clarity.Pull Request Checklist