ci: fix MSRV jobs with cargo update #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
ci/fix_msrv
branch
4 times, most recently
from
5ff5859 to
646ab54
Compare
notmandatory
force-pushed
the
ci/fix_msrv
branch
from
646ab54 to
fdb9d18
Compare
notmandatory
added
documentation
|
@willowenss this PR fixes the bdk-cli MSRV dependencies issue. Please give it a review and an After I merge it you'll need to rebase your branch for #156, let me know if you need help doing this. |
Sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
cargo updatein the CI build test job to pin dependencies to work with MSRV 1.57.0. Also updated README with corresponding instructions.Notes to the reviewers
This is how the rust-bitcoin and other bdk projects are going to be pinning dependencies from now on.
Changelog notice
None.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing