Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventSenderExt to work with Wallet directly #88

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rustaceanrob
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made comments, otherwise this looks good.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated
fn add_revealed_scripts<'a>(
&'a self,
wallet: &'a bdk_wallet::Wallet,
) -> FutureResult<(), kyoto::ClientError>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I just learned that rust 1.83 will issue a warning for an "elided named lifetime"

warning: elided lifetime has a name
   --> src/lib.rs:502:22
    |
499 |     fn add_revealed_scripts<'a>(
    |                             -- lifetime `'a` declared here
...
502 |     ) -> FutureResult<(), kyoto::ClientError>;
    |                      ^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default

src/lib.rs Outdated
}
Ok(())
}
Box::pin(_add_revealed(&self, wallet))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also caught by CI but apparently we allow warnings. We could change clippy in CI to cargo clippy --all-targets -- -Dwarnings

Suggested change
Box::pin(_add_revealed(&self, wallet))
Box::pin(_add_revealed(self, wallet))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can follow up with that patch to CI

@rustaceanrob
Copy link
Collaborator Author

Updated with patches to those comments. cargo clippy --all-targets on nightly showed no lints.

@rustaceanrob rustaceanrob force-pushed the client-ext-12-14 branch 2 times, most recently from 9fc9485 to ef79790 Compare December 17, 2024 02:44
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c182d50

@rustaceanrob rustaceanrob merged commit b3f3c9c into bitcoindevkit:master Dec 17, 2024
2 checks passed
@rustaceanrob rustaceanrob deleted the client-ext-12-14 branch December 17, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants