Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle.yml: Add ubuntu-24.04-arm to matrix #109

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

msgilligan
Copy link
Member

No description provided.

@msgilligan
Copy link
Member Author

@msgilligan msgilligan force-pushed the msgilligan/github-actions-ubuntu-arm branch from 021bf17 to 38cd413 Compare January 16, 2025 23:24
@msgilligan msgilligan marked this pull request as ready for review January 16, 2025 23:31
@msgilligan msgilligan requested a review from schildbach January 16, 2025 23:32
@msgilligan
Copy link
Member Author

@schildbach I think we should go ahead and merge this and we can remove the workaround when it is no longer needed.

@schildbach
Copy link
Member

Why not wait a bit for GitHub to fix the issue? The arm image is something like a preview. What benefit does it have to use it this early? Imo you risk breaking your build at any time if you merge this.

Note general arm compatibility is already tested via the macOS-14 image.

@schildbach
Copy link
Member

See actions/partner-runner-images#27 (comment) – ideally the workaround will not be necessary after that.

@msgilligan msgilligan force-pushed the msgilligan/github-actions-ubuntu-arm branch from 38cd413 to 73b1a2a Compare January 18, 2025 00:10
@msgilligan
Copy link
Member Author

@schildbach work-around removed, rebased, tests passing!

@msgilligan msgilligan merged commit 519b63e into master Jan 19, 2025
14 of 16 checks passed
@msgilligan msgilligan deleted the msgilligan/github-actions-ubuntu-arm branch January 19, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants