Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(individual-transcript-page): Transcript Metadata Card #16

Closed

Conversation

0tuedon
Copy link
Collaborator

@0tuedon 0tuedon commented Sep 9, 2024

What to note

  • To test this component I have created a temporary route "/test-component" or preview here You will be able to see the component used

  • BDP-UI components that were not present were created into the component/svgs path. and this would be removed once the BDP UI components have been updated

  • I have closed this Transcript bio data component #13

IgboPharaoh and others added 7 commits August 8, 2024 15:06
…ubmodule-path

Fix/submodule path and build errors
a simplification of the config alongside some changes to
the pages in order to show the structure based on the
new simplified implementation.
* build: install bdp-ui icons

* build: set config requirements

* style: add assets and icons

* chore: remove redundant styles, add menu data

* chore: add landing page components

* chore: create landing page with responsive styles

* fix: build error

* replace image assets

* add mobile menu and app menu

* install bdp-ui from npm

* complete landing page requirements

* remove search icon, change image path and add priority prop
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 0:48am

@kouloumos
Copy link
Member

The information that are displayed in this component we are calling them "metadata", so please use this language where applicable. So this component should be "TranscriptMetadataCard", and actually this is the name that @Emmanuel-Develops called it when created the related issue: #10

@0tuedon
Copy link
Collaborator Author

0tuedon commented Sep 9, 2024

#10

Thanks @kouloumos , I wasn't tagged to the issue and used the name I saw on figma
Screenshot 2024-09-09 at 10 29 59

@kouloumos
Copy link
Member

Thanks @kouloumos , I wasn't tagged to the issue and used the name I saw on figma Screenshot 2024-09-09 at 10 29 59

I understand the confusion. I wasn’t aware of the specific names on Figma either, so I’ll review them and update the names as needed. Also, @Emmanuel-Develops is working on creating an issue for each task so that issues can serve as the single source of truth moving forward.

@kouloumos kouloumos changed the title Transcript Bio Data Implementation feat(individual-transcript-page): Transcript Metadata Card Sep 9, 2024
Comment on lines +74 to +78
<p
key={topic}
className=" max-content py-[4.11px] px-[16.43px] rounded-[5.13px] bg-gray-custom-700 max-md:px-3 max-md:py-[2px] max-xl:text-[13px] max-md:text-sm max-md:border max-md:border-gray-custom-300 max-md:leading-[100%]"
>
{topic}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topics are clickable and redirect to the specific topic's page

Comment on lines +92 to +97
<p
key={speaker}
className=" max-content py-[4.11px] px-[16.43px] rounded-[5.13px] bg-gray-custom-700 max-md:px-3 max-md:py-[2px] max-xl:text-[13px] max-md:text-sm max-md:border max-md:border-gray-custom-300 max-md:leading-[100%]"
>
{speaker}
</p>
Copy link
Member

@kouloumos kouloumos Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speakers are clickable and redirect to the specific speaker's page

@Emmanuel-Develops
Copy link
Collaborator

Apologies for the delay in review @0tuedon. The plan was to work on the transcript page next, priorities have shifted unfortunately to explore page, and this component will not be used until then.

Transcript metadata will be put on hold as missing pieces are yet to be built in the explore page.
issue: #17

@kouloumos
Copy link
Member

@0tuedon should we close this one?

@kouloumos kouloumos closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants