Add Lee Controller as option in Kconfig #1454
Merged
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
When using the
make menuconfig
tool, it is currently not possible to select theLee controller
as the controller, even though all other types of controllers defined insrc/modules/src/controller/controller.c
can be selected. It looks like theLee controller
was simply forgotten about in theKconfig
file, as there are checks to see whetherCONFIG_CONTROLLER_LEE
is set within thecontroller.c
file here. The Lee Controller was added in #1343 but this PR did not modify theKconfig
file.Solution
With this PR, one can select the
Lee controller
as the controller option:Verification
After running
make menuconfig
and selecting theLee controller
option, the following is put intobuild/.config
:After
make
is run, thebuild/include/generated/autoconf.h
will contain the proper preprocessor commandand then the
Lee controller
is selected incontroller.c
. This was also verified in thecfclient
tool's Console which logs theDEBUG_PRINT
statements.