Use default latency implementation for latency test #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bitcraze/crazyflie-lib-python#492 there is a default implementation in the lib for latency. Retrieve the latency from here instead of using the custom implementation. This means we stop discerning between large and small packet latency.
gemenerik
force-pushed
the
rik/latency_test
branch
from
fa8a996 to
f2f1722
Compare
ToveRumar
reviewed
Jan 8, 2025
For neatness; don't create a second cf object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since crazyflie-lib-python#492, there is a default implementation in the library for latency using the echo channel.
The latency testing implementation in this repository conflicts with the new library implementation because it also uses the echo channel but assumes exclusive control of it (no header checks or similar safeguards). This causes occasional failures in the current latency tests when one of the new implementation's latency pings is read by the current test instead. Examples of these failures can be seen here:
Run 1
Run 2
This PR fixes the issue by using the latency values provided by the new default latency implementation rather than the custom implementation.
One side effect is that we can no longer differentiate between large and small packet latency, as the new implementation uses fixed-size packets. However, we have not observed any significant difference between these in practice.