Merge pull request #15 from ZIMkaRU/bugfix/fix-clone-deep-to-not-thro…

…w-err-for-non-obj

Fix clone deep to not throw err for non obj

CHANGELOG

@@ -1,3 +1,6 @@
+# 1.5.1
+- fix: cloneDeep should not throw an error when cloning non-objects
+
 # 1.5.0
 - feat: shuffle
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bitfinex/lib-js-util-base",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "general utils",
   "main": "index.js",
   "scripts": {

src/cloneDeep.js

@@ -1,5 +1,16 @@
 'use strict'
 
-const cloneDeep = (obj) => JSON.parse(JSON.stringify(obj))
+const isObject = require('./isObject')
+
+const cloneDeep = (obj) => {
+  if (obj instanceof Function) {
+    return {}
+  }
+  if (!isObject(obj)) {
+    return obj
+  }
+
+  return JSON.parse(JSON.stringify(obj))
+}
 
 module.exports = cloneDeep

test/cloneDeep.js

@@ -3,7 +3,7 @@
 /* eslint-env mocha */
 
 const assert = require('assert')
-const { cloneDeep } = require('../index')
+const { cloneDeep, isPlainObject } = require('../index')
 
 describe('cloneDeep', () => {
   it('should deep clone objects', () => {
@@ -19,4 +19,20 @@ describe('cloneDeep', () => {
     assert.deepStrictEqual(obj, clone)
     assert.notStrictEqual(obj, clone)
   })
+
+  it('should not throw an error when cloning non-objects', () => {
+    const sources = [undefined, Symbol('a'), () => {}]
+
+    for (const obj of sources) {
+      const clone = cloneDeep(obj)
+
+      if (obj instanceof Function) {
+        assert.strictEqual(isPlainObject(clone), true)
+
+        return
+      }
+
+      assert.deepStrictEqual(obj, clone)
+    }
+  })
 })