Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform support for web #193

Merged
merged 31 commits into from
Nov 26, 2024
Merged

Platform support for web #193

merged 31 commits into from
Nov 26, 2024

Conversation

hawk23
Copy link
Collaborator

@hawk23 hawk23 commented Nov 21, 2024

Description

Initial support for web

Supported Configs:

  • PlayerConfig
    • key
    • licensing.delay
    • playback
      • autoplay
      • muted
  • SourceConfig
    • title
    • description
    • dash
    • hls
    • poster

Supported API calls:

  • loadSource(source)
  • play
  • pause
  • mute
  • unmute
  • seek(time)
  • timeShift(timeShift)
  • getCurrentTime
  • getTimeShift
  • getDuration
  • getMaxTimeShift
  • isLive
  • isPlaying
  • isAirplayActive
  • isAirplayAvailable
  • castVideo
  • castStop
  • isCastAvailable
  • isCasting
  • showAirPlayTargetPicker
  • destroy

Supported events:

  • play
  • playing
  • paused
  • timechanged
  • seek
  • seeked
  • timeshift
  • timeshifted
  • playbackfinished
  • error
  • muted
  • unmuted
  • warning
  • ready
  • sourceloaded
  • sourceunloaded

Changes

  • Introduce abstraction for platform communication -> Method and event channels are not needed for web: lib/src/platform
  • Introduce abstraction to check for current platform. Platform.isAndroid / Platform.isIOS cannot be used for web as it produces errors
  • Introduce player plugin for web: lib/src/platform/web
  • Add example app for web: example/web

Tests

  • Due to technical limitations, system tests cannot yet be executed for web
  • System tests passing for mobile platforms
  • Manual testing was done

Checklist (for PR submitters and reviewers)

  • 🗒 CHANGELOG.md entry for new/changed features, bug fixes or important code changes
  • 🧪 Tests added and/or updated
  • 📢 New public API is fully documented -> No new public API added

@hawk23 hawk23 self-assigned this Nov 21, 2024
@hawk23 hawk23 changed the title Support platform web Platform support for web Nov 22, 2024
@hawk23 hawk23 marked this pull request as ready for review November 26, 2024 08:35
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of unused code

@hawk23 hawk23 merged commit da0f351 into main Nov 26, 2024
4 checks passed
@hawk23 hawk23 deleted the feature/support-web branch November 26, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant