Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document race condition and produce meaningful error #196

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

hawk23
Copy link
Collaborator

@hawk23 hawk23 commented Nov 26, 2024

Description

  • Make _methodChannel optional and introduce null check to avoid "LateInitializationError" when accessing method channel before it becomes available
    • Produce meaningful error instead
  • Document potential race condition

Checklist (for PR submitters and reviewers)

  • 🗒 CHANGELOG.md entry for new/changed features, bug fixes or important code changes: n/a
  • 🧪 Tests added and/or updated
  • 📢 New public API is fully documented

@hawk23 hawk23 self-assigned this Nov 26, 2024
@hawk23 hawk23 marked this pull request as ready for review November 26, 2024 17:13
@hawk23 hawk23 merged commit 593feab into main Nov 26, 2024
4 checks passed
@hawk23 hawk23 deleted the feature/document-race-condition branch November 26, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant