Add PiP support on iOS - Events and Page #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123mpozzi
changed the title
Co-authored-by: Mr. Graf <[email protected]>
Co-authored-by: Mr. Graf <[email protected]>
Co-authored-by: Mr. Graf <[email protected]>
Co-authored-by: Mr. Graf <[email protected]>
Co-authored-by: Mr. Graf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support iOS-related Picture-in-Picture (PiP) events.
And add a new sample Page which will be used to test the upcoming PiP feature.
Additions
Events
PictureInPictureEnterwhich is emitted when the player view is about to enter Picture-in-Picture mode.PictureInPictureExitwhich is emitted when the player view is about to exit Picture-in-Picture modePictureInPictureEnteredwhich is emitted when the player view finishes entering Picture-in-Picture mode.PictureInPictureExitedwhich is emitted when the player view finishes exiting Picture-in-Picture mode.Sample Page
PictureInPicturepage to test PiP and show how it can be integrated and used (iOS-only for now)Testing
Apply pipEvents.patch to force-enable PiP on iOS side.
Then open the new Picture-in-Picture sample page and check for the added events being fired in the output console when using the native UI button.