Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Dart format in CI on every push to a PR #81

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Check Dart format in CI on every push to a PR #81

merged 5 commits into from
Dec 1, 2023

Conversation

hawk23
Copy link
Collaborator

@hawk23 hawk23 commented Dec 1, 2023 •
edited
Loading

This PR adds a Dart code formatting check to be executed on every push to a PR branch

See this test run as an example: https://github.com/bitmovin/bitmovin-player-flutter/actions/runs/7058335114/job/19213693215?pr=81

@hawk23 hawk23 self-assigned this Dec 1, 2023
@hawk23 hawk23 marked this pull request as ready for review December 1, 2023 09:56
@hawk23 hawk23 requested review from a team as code owners December 1, 2023 09:56
@hawk23 hawk23 requested review from 123mpozzi and removed request for a team December 1, 2023 09:56
123mpozzi
123mpozzi approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@123mpozzi 123mpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine 💪 !!

@hawk23 hawk23 merged commit d9b5817 into main Dec 1, 2023
3 checks passed
@hawk23 hawk23 deleted the feature/check-dart-format-on-each-pr branch December 1, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123mpozzi 123mpozzi 123mpozzi approved these changes

Assignees

@hawk23 hawk23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawk23 @123mpozzi