-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Picture in Picture #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
private val isPictureInPictureSupported: Boolean | ||
get() = Build.VERSION.SDK_INT >= Build.VERSION_CODES.O | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: could be a top level function in the file to make it clear that it does not need any state from the view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💪
- I see that the
PictureInPictureAvailabilityChanged
event is not implemented for Flutter. As it's Android only, do you think it would make sense to expose it? - As discussed on Slack, when
_player.loadSourceConfig(_sourceConfig);
is commented out in the PiP sample (no source loaded into the player), PiP does not work anymore on my personal Android device. The floating window does not appear and the player view just goes to Fullscreen mode.
Co-authored-by: Lukas Knoch-Girstmair <[email protected]>
I actually missed this event. I'll create a follow up ticket and we can tackle this in another PR 🙂
I looked into this and found some limitation in the native SDK |
Description
This PR introduces Picture in Picture handling on Android including a sample usage.
Prework PRs:
#85
#86
Changes
FlutterPictureInPictureHandler
Tests
Checklist (for PR submitters and reviewers)
CHANGELOG.md
entry for new/changed features, bug fixes or important code changes