Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node sass shenanigans on node v16 #442

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

ravloony
Copy link
Contributor

@ravloony ravloony commented Feb 22, 2022

The build was failing on node 16 due to the node-sass version pulled in by gulp-sass 4.

This PR replaces node-sass with sass, as it was not possible to support node 10 through 16 otherwise.

This PR fixes #422

@ravloony ravloony requested a review from stonko1994 February 22, 2022 17:38
@ravloony ravloony merged commit 9c18dcb into develop Feb 23, 2022
@ravloony ravloony deleted the maintenance/fix-node-sass-shenanigans-node-16 branch February 23, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ERR! Build failed with error code: 1 while running npm install
3 participants