Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate regions for CEA608 rows #665

Merged
merged 9 commits into from
Jan 8, 2025

Conversation

felix-hoc
Copy link
Contributor

@felix-hoc felix-hoc commented Jan 7, 2025

Description

Issue: PW-22216

Problem

For CEA-608 captions, the “window color” + “window opacity” affect the whole subtitle overlay, blocking the view on the content.

Changes

  • create separate region components for CEA-608 rows
  • the absolute vertical position is now assigned to each row / region
    • as CEA-608 has exactly 15 rows, this is pre-calculated in CSS
  • the actual cues are no longer positioned absolute-ly, and only hold the left offset

Checklist (for PR submitter and reviewers)

  • CHANGELOG entry

@felix-hoc felix-hoc marked this pull request as ready for review January 8, 2025 09:25
Copy link
Contributor

@bitmovin-kenny bitmovin-kenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good even with two CEA Caption tracks active at the same time.

@felix-hoc felix-hoc merged commit a5ca3fb into develop Jan 8, 2025
3 checks passed
@felix-hoc felix-hoc deleted the feature/fix-cea-caption-styling branch January 8, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants