Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter P2K16 to have door circles, similar to tools circles. #149

Open
eliasbakken opened this issue Feb 10, 2021 · 6 comments
Open

Alter P2K16 to have door circles, similar to tools circles. #149

eliasbakken opened this issue Feb 10, 2021 · 6 comments
Assignees

Comments

@eliasbakken
Copy link
Contributor

As a part of the moving to BV9 in September 2021, it would be good to have the possibility to add new door circles that can send messages on a specific topic similar to tools.
That way people can set up door locks on office doors in the old and new building.

@omega
Copy link
Contributor

omega commented Feb 11, 2021

So we want an admin interface similar to tools for the buttons on the front page?

@eliasbakken
Copy link
Contributor Author

eliasbakken commented Feb 11, 2021 via email

@trygvis
Copy link
Contributor

trygvis commented Feb 11, 2021

The doors are defined in the code, so the required circle can just be a part of the code.

If we ever make the doors list a part of the database something tools like would be useful.

@omega
Copy link
Contributor

omega commented Feb 11, 2021

@trygvis I thought that was the request here, to make it easier to add more doors..?

@omega
Copy link
Contributor

omega commented Feb 11, 2021

@eliasbakken I guess one thing that needs to be thought about is who can add/administer circles for doors? Like if I set up a new lock on my office, we need to prevent someone else from just adding a new door with the same mqtt-topic etc?

@trygvis
Copy link
Contributor

trygvis commented Feb 11, 2021

@trygvis I thought that was the request here, to make it easier to add more doors..?

Nope, just have circle-based authorization in addition to the existing membership/office checks.

omega added a commit to bitraf/p2k16 that referenced this issue Aug 30, 2021
This allows us to have a set of circles for each door, and without
membership in that circle, you wont be able to open that door.

This check does not apply to employees of companies, only for paying
members.

If you attempt to open multiple doors, none will open if you lack any of
the circles.

For now all doors have `door` only, this is intended used at BV9 to
limit access to certain areas.

bitraf/infrastructure#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants