Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different circles for each door #109

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Add support for different circles for each door #109

merged 2 commits into from
Aug 30, 2021

Conversation

omega
Copy link
Contributor

@omega omega commented Aug 30, 2021

This allows us to have a set of circles for each door, and without
membership in that circle, you wont be able to open that door.

This check does not apply to employees of companies, only for paying
members.

If you attempt to open multiple doors, none will open if you lack any of
the circles.

For now all doors have door only, this is intended used at BV9 to
limit access to certain areas.

bitraf/infrastructure#149

This allows us to have a set of circles for each door, and without
membership in that circle, you wont be able to open that door.

This check does not apply to employees of companies, only for paying
members.

If you attempt to open multiple doors, none will open if you lack any of
the circles.

For now all doors have `door` only, this is intended used at BV9 to
limit access to certain areas.

bitraf/infrastructure#149
@omega omega requested review from mastensg and trygvis August 30, 2021 17:14
@omega
Copy link
Contributor Author

omega commented Aug 30, 2021

this is very "least possible effort", so no UI changes for now, just the backend support

@omega
Copy link
Contributor Author

omega commented Aug 30, 2021

one thing I am unsure about, is if the buttons on the frontpage should only show up if you have the door circle (today that is the case, with this PR, it would show up for any paying member, but the buttons would give error with missing cirlces)

Copy link
Contributor

@trygvis trygvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, showing inaccessible doors is fine.

I think we want the list of doors to be served by the backend soon, that way we can have some more control over what we expose.

@omega
Copy link
Contributor Author

omega commented Aug 30, 2021

Yeah we want that at some point 🙂

@omega omega merged commit 1b677cf into master Aug 30, 2021
@omega omega deleted the door-cirlces branch August 30, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants