[PM-15918] Update bitwarden SDK #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vault export to use the correct SSH key property names.
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
| @@ -26,7 +26,7 @@ androidxSplash = "1.1.0-rc01" | |||
| androidXAppCompat = "1.7.0" | |||
| androdixAutofill = "1.1.0" | |||
| androidxWork = "2.10.0" | |||
| bitwardenSdk = "1.0.0-20241030.101847-8" | |||
| bitwardenSdk = "1.0.0-20250107.132220-70" | |||
There was a problem hiding this comment.
Looks like this version couldn't be found
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4529 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 603 603
Lines 40235 40235
Branches 5692 5692
=======================================
Hits 35529 35529
Misses 2722 2722
Partials 1984 1984 ☔ View full report in Codecov by Sentry. |
SaintPatrck
commented
Jan 9, 2025
There was a problem hiding this comment.
This file was not being used and there were SDK references to be updated. Removed the file instead of updating it.
mpbw2
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15918
📔 Objective
Fixes vault export to use the correct SSH key property names.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes