Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validator to generator #12735

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

willmartian
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.20%. Comparing base (966e8d3) to head (c1a6e6e).
Report is 5 commits behind head on main.

โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12735      +/-   ##
==========================================
- Coverage   34.29%   34.20%   -0.09%     
==========================================
  Files        2901     2937      +36     
  Lines       89705    90141     +436     
  Branches    16853    16926      +73     
==========================================
+ Hits        30760    30832      +72     
- Misses      56523    56870     +347     
- Partials     2422     2439      +17     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ fc333b34-88e7-458c-a5ed-861bd23c153a

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant