-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13306] - add missing elements to browser vault trash list #12736
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI changes look good, just a failing unit test to clean up
@@ -58,6 +65,18 @@ export class TrashListItemsContainerComponent { | |||
private router: Router, | |||
) {} | |||
|
|||
/** | |||
* The tooltip text for the organization icon for ciphers that belong to an organization. | |||
* @param cipher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ (non-blocking): This is a personal opinion, I think that TypeScript provides enough context to not need @param
in most cases unless an explanation of the parameter is needed. Take it or leave it!
* @param cipher |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12736 +/- ##
=======================================
Coverage 34.14% 34.14%
=======================================
Files 2937 2937
Lines 90340 90348 +8
Branches 16963 16965 +2
=======================================
+ Hits 30846 30851 +5
- Misses 57039 57041 +2
- Partials 2455 2456 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving; screenshots in the PR look as expected.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13306
📔 Objective
This PR adds missing elements to the browser vault trash list. Notably:
An attempt was made to have the common elements between the active and vault lists in a separate component, however, the fact that the button elements must be a direct descendent of the parent doesn't allow for this.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes