Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13306] - add missing elements to browser vault trash list #12736

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13306

📔 Objective

This PR adds missing elements to the browser vault trash list. Notably:

  • sub-text
  • organization icon
  • collection tooltip
  • attachment icon

An attempt was made to have the common elements between the active and vault lists in a separate component, however, the fact that the button elements must be a direct descendent of the parent doesn't allow for this.

📸 Screenshots

Before After
Screenshot 2025-01-07 at 2 21 24 PM Screenshot 2025-01-07 at 2 22 51 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner January 7, 2025 22:23

This comment was marked as off-topic.

danielleflinn
danielleflinn previously approved these changes Jan 7, 2025
Copy link
Collaborator

@nick-livefront nick-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good, just a failing unit test to clean up

@@ -58,6 +65,18 @@ export class TrashListItemsContainerComponent {
private router: Router,
) {}

/**
* The tooltip text for the organization icon for ciphers that belong to an organization.
* @param cipher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ (non-blocking): This is a personal opinion, I think that TypeScript provides enough context to not need @param in most cases unless an explanation of the parameter is needed. Take it or leave it!

Suggested change
* @param cipher

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 34.14%. Comparing base (bb61b3d) to head (6691b75).
Report is 19 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...-container/trash-list-items-container.component.ts 0.00% 4 Missing ⚠️
.../vault/popup/services/vault-popup-items.service.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12736   +/-   ##
=======================================
  Coverage   34.14%   34.14%           
=======================================
  Files        2937     2937           
  Lines       90340    90348    +8     
  Branches    16963    16965    +2     
=======================================
+ Hits        30846    30851    +5     
- Misses      57039    57041    +2     
- Partials     2455     2456    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielleflinn danielleflinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving; screenshots in the PR look as expected.

@jaasen-livefront jaasen-livefront merged commit 06ca00f into main Jan 9, 2025
36 of 37 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-13306 branch January 9, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants